You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
ci(j5): run the release's builds side by side - #1007
A nightly takes about 25 minutes, and most of that is jobs waiting on work they don't use: the CLI archives and the Windows build wait for the signed desktop DMG, Windows waits for the macOS CLI archive, and every build waits for verify. A release also asks for a macOS runner four times. On 10 November, with GitHub short of macOS arm64 runners, each request was another 15-minute wait and cancellation (run 16 took five attempts).
What changed
Desktop build inside J5 Release.J5 Nightly now calls only J5 Release, which runs the signed desktop build as its own desktop job alongside everything else. A manual J5 Release still publishes the build run it names, so desktop is skipped there.
Two CLI archive jobs instead of one matrix. Windows embeds the Linux archive, and now waits only for that. Both jobs share their steps through a YAML anchor.
verify gates publishing, not the builds. If it fails, nothing is published; only build minutes are lost.
Two macOS runners instead of four. The darwin-arm64 CLI archive builds its own resource monitor (same cache key as j5-resource-monitors.yml). The darwin-x64 monitor is dropped: J5 ships no Intel Mac CLI and nothing uses it.
before: resolve → desktop → release/resolve → verify+monitors → CLI archives → windows → publish (~25 min, measured)
after: resolve → [desktop | verify | monitors → linux archive → windows | mac archive] → publish (~12–13 min, estimated)
Verified: actionlint 1.7.12 is clean on the changed workflows apart from a pre-existing github.run_started_at finding in a line this PR doesn't touch, and it parses the anchor. Both archive jobs resolve to the same 23 steps.
Not verified before merge: these workflows only run from j5/main (J5 Nightly) or by publishing a release, so the next nightly is the first real run of the new graph and of the in-job monitor build. The timing above is an estimate from the 3 November nightly's job times.
Checklist
One concern: the description has no "also"
Tests cover the changed behavior: CI config only; the next nightly is the test
UI changes: none
Live testing: nothing to live-test
Upstream-owned files: none touched; all four workflows are J5's
Upstream product: unchanged
Surfaces: only J5's release workflows change
Docs: the runbook's description of the release still holds
Only the publish job now waits for every build. The desktop build moves
into J5 Release, the two CLI archives become separate jobs so Windows
waits only for the Linux one, and verify gates publishing instead of the
builds. The darwin-arm64 archive builds its own resource monitor and the
unused darwin-x64 monitor is dropped, so a release asks for two macOS
runners instead of four.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
No actionable comments were generated in the recent review.
Walkthrough
J5 Release now schedules the desktop build and separate Linux and macOS CLI archive jobs. The workflows update resource-monitor handling and release-job dependencies. J5 Nightly no longer runs a separate desktop build job.
J5 Release calls the desktop build workflow for eligible stamped releases. J5 Nightly no longer has a separate desktop build job. The workflow comments describe the desktop artifact source for called and manual runs.
The resource-monitor workflow retains Linux x64 and Windows x64 targets and removes its macOS targets. J5 Release splits Linux and macOS CLI archives into separate jobs. The Linux job downloads its monitor artifact; the macOS job restores the arm64 monitor from cache or builds it locally.
The Windows job now waits for the Linux archive. The release job waits for verification, both CLI archives, and Windows. It requires the desktop job for stamped runs and allows that job to be skipped otherwise.
Jacksondr5/j5code#1005: Changes the runner and job configuration for the same desktop and macOS CLI release builds.
Jacksondr5/j5code#537: Changes the versioning and J5 Nightly/J5 Release caller flows that these workflow updates further revise.
Jacksondr5/j5code#773: Adds the Windows build that now waits for the Linux CLI archive.
Suggested labels:size:M
Suggested reviewers:bryantderosier
Merge Risk: Minimal · up to a86c2
The release workflow changes are ready for normal checks; no concrete issue requiring a pre-merge fix was established.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title clearly summarizes the main change: running release builds side by side.
Description check
The description explains the problem and changes, reports validation and untested workflow behavior, and completes the applicable checklist. It notes that the next nightly will be the first real run.
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Reviewing files that changed from the base of the PR and between 4918bad and a86c269.
Files selected for processing: 4
.github/workflows/j5-macos-build.yml
.github/workflows/j5-nightly.yml
.github/workflows/j5-release.yml
.github/workflows/j5-resource-monitors.yml
Included review availability: This review used your included allowance. 2 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 3 reviews per hour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size:L100-499 effective changed lines (test files excluded in mixed PRs).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-actions
Bot
added
the
vouch:trusted
Problem
A nightly takes about 25 minutes, and most of that is jobs waiting on work they don't use: the CLI archives and the Windows build wait for the signed desktop DMG, Windows waits for the macOS CLI archive, and every build waits for
verify. A release also asks for a macOS runner four times. On 10 November, with GitHub short of macOS arm64 runners, each request was another 15-minute wait and cancellation (run 16 took five attempts).What changed
J5 Nightlynow calls onlyJ5 Release, which runs the signed desktop build as its owndesktopjob alongside everything else. A manualJ5 Releasestill publishes the build run it names, sodesktopis skipped there.verifygates publishing, not the builds. If it fails, nothing is published; only build minutes are lost.j5-resource-monitors.yml). The darwin-x64 monitor is dropped: J5 ships no Intel Mac CLI and nothing uses it.Verified:
actionlint1.7.12 is clean on the changed workflows apart from a pre-existinggithub.run_started_atfinding in a line this PR doesn't touch, and it parses the anchor. Both archive jobs resolve to the same 23 steps.Not verified before merge: these workflows only run from
j5/main(J5 Nightly) or by publishing a release, so the next nightly is the first real run of the new graph and of the in-job monitor build. The timing above is an estimate from the 3 November nightly's job times.Checklist
Claude Opus 5.5 in Claude Code (J5 Code).
🤖 Generated with Claude Code